-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate project to Jetpack Compose #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work! I've left some minor cleanup related comments but none are a blocker.
import androidx.compose.ui.text.style.TextAlign | ||
|
||
@Composable | ||
internal fun OutlinedIconButton( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name is IconOutlinedButton
, you should probably rename it to match the function.
what-the-stack/src/main/java/com/haroldadmin/whatthestack/ui/components/ScrollableText.kt
Outdated
Show resolved
Hide resolved
…mposables, use version references in build.gradle
This PR migrates WhatTheStack to use Jetpack Compose, Android's new declarative UI toolkit.
I've maintained feature parity with the existing stable version of the library, but will
release this as a new major release after it's been tested through a few pre-release builds.